-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move search filters above input so not hidden behind autocomplete. #114
base: trunk
Are you sure you want to change the base?
Conversation
fb53f43
to
668e6fd
Compare
This has been rebased now that #75 has merged. |
668e6fd
to
e13bbdb
Compare
Nice. This works really well on the search results page. 👍 On the I wonder if we should consider hiding it there ( Note: find my own idea painful since I spent time styling it in #75. :) Thoughts? |
Yeah, I can see that. I think it could be designed to look more like a secondary thing than a primary one. One way could be to move the filters back down below, but have them positioned absolutely so they're not covered by the autocomplete results. Or maybe have them on the left/right instead of top/bottom?
Personally, I just assume that an unfiltered query is going to return too many results, even with more powerful engines like Google. it feels like more work to me to have to sift through them, and then to search a 2nd time w/ filtered results. I usually know upfront what type I'm looking for. That's probably personal preference, though, and I also don't have any data about how common either approach is |
I looked through some GA data to inform this chat and unfortunately, we don't have event logging on the filters. The only relevant piece is that few users enter a keyword, select a filter, and press enter (keyword/filter order not important). Most users do end up on a specific page after the Note: We don't know how many attempts the user takes to find the specific page though or whether they eventually add a filter. Another interesting piece is that a large proportion of users click on the [filters] navigation link (which was removed in #75), get to the filter list, then return back to the reference home page (presumably to search from there). This does suggest that users are intending to find a specific page, which is more often than not a function (2. hook) and they recognize that working through the numerous pages is not the best approach. If we were trying hard to remove these filters, we could probably argue that functions/hooks could be given more weight and/or clearer types in the autocomplete (you mention that in #120) and that may be all that is needed. |
Fixes #57
Intersects with #75trunk
, typeaction
into the search on/reference
, notice that it covers the filter checkboxesThis can wait until #75 is merged, and then be rebased.